Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logger: Set allow_logging_basic_config as False #463

Merged
merged 1 commit into from
Jan 17, 2025
Merged

logger: Set allow_logging_basic_config as False #463

merged 1 commit into from
Jan 17, 2025

Conversation

ilkecan
Copy link
Contributor

@ilkecan ilkecan commented Nov 14, 2024

Description of the change

A handler shouldn't configure the root logger. This was really unexpected.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell added this to the 1.1.1 milestone Nov 18, 2024
@danielmorell danielmorell self-assigned this Nov 18, 2024
@danielmorell danielmorell self-requested a review January 17, 2025 16:47
@danielmorell danielmorell modified the milestones: 1.1.1, 1.2.0 Jan 17, 2025
danielmorell
danielmorell approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @ilkecan!

@danielmorell danielmorell merged commit 8805c6f into rollbar:master Jan 17, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmorell danielmorell danielmorell approved these changes

Assignees

@danielmorell danielmorell

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ilkecan @danielmorell